C#: Adopt shared variable capture library #15665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private module CaptureInput implements Shared::InputSig<Location> { | ||
| private import csharp as Cs |
Check warning
Code scanning / CodeQL
Names only differing by case
hvitved
force-pushed
the
csharp/variable-capture
branch
3 times, most recently
from
b043381 to
a1c048b
Compare
hvitved
force-pushed
the
csharp/variable-capture
branch
2 times, most recently
from
4e861b0 to
7d8857f
Compare
hvitved
force-pushed
the
csharp/variable-capture
branch
5 times, most recently
from
d6af861 to
3e1ac2e
Compare
hvitved
force-pushed
the
csharp/variable-capture
branch
from
3e1ac2e to
acd5219
Compare
michaelnebel
approved these changes
Feb 28, 2024
Contributor
michaelnebel
left a comment
michaelnebel
left a comment
There was a problem hiding this comment.
This looks plausible to me, but I must admit I am not sufficiently familiar with code to provide a semantic review.
Good work :-D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the shared variable capture library to C#.
Previously, the SSA library had ad-hoc support for variable capture, but that support has now been removed (actually, we still allow captured variables where all writes happen in the defining method), and we instead rely solely on the implementation from the shared library.
The implementation of the input to the shared library is somewhat standard, except local functions need to be treated as if they were lambdas, which prompts the need for additional synthetic nodes (
LocalFunctionCreationNode) and local/jump steps (LocalFunctionCreationNode.getAnAccess).Since the SSA library now has limited support for captured variables, we apply control-flow insensitive data flow through captured variables when resolving lambda calls.
DCA reports a bunch of new results, as expected, including a new TP in WebGoat, where data flows through a captured string builder.